Automatically change theme styles when dark mode is enabled or disabled.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 1.0.0 (13) | Unreviewed |
| 1.0.0 (12) | Rejected |
| 1.0.0 (11) | Rejected |
| 1.0.0 (10) | Rejected |
| 1.0.5 (9) | Rejected |
| 1.0.5 (8) | Rejected |
| 1.0.4 (7) | Rejected |
| 1.0.3 (6) | Rejected |
| 1.0.2 (5) | Rejected |
| 1.0.1 (4) | Rejected |
| 1.0.0 (3) | Rejected |
| 1.0.0 (2) | Rejected |
| 1.0.0 (1) | Rejected |
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. You cannot get other extension's settings like that (line 377 `extension.js`). 3. You should hold all timeout ids in a property and loop over it on disable to remove it. The way you are doing it is really hard to review for clean up. 4. Is this code generated by AI? If so, we have a rule for that. You are saying this is a fork of other extension by linking to 404 URL: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Thank you for the detailed review! I've addressed all the technical points: 1. Replaced all manual connect()/disconnect() calls with connectObject()/disconnectObject() throughout the extension. 2. Fixed the user-theme settings access — instead of instantiating Gio.Settings directly with the schema, I now use Main.extensionManager.lookup(uuid).getSettings(...) to retrieve the settings through the extension object properly. 3. Replaced the _sourceIds object with a _timeoutIds array. All timeout IDs are pushed into it when created, and disable() now loops over the array to remove them all cleanly. 4. Regarding the AI question: parts of this extension were developed with AI assistance, but all logic was reviewed, understood, and adjusted by me. The broken link was a mistake and has been removed. This is not a blindly generated extension — I'm happy to make any further adjustments the review team requires. I will send the new corrected version.