Review of "DayNight Theme Sync" version 1.0.3 (6)

Details Page Preview

Automatically change theme styles when dark mode is enabled or disabled.

Extension Homepage
https://github.com/phenrique-coder/DayNight-Theme-Sync

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:137
        this._timeouts.shellTheme = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 400, () => {
          this._changeShellTheme(isDm ? this._themes.shellDark : this._themes.shellLight);
          this._timeouts.shellTheme = 0;
          return GLib.SOURCE_REMOVE;
        })

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:144
        this._timeouts.transition = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
          if (this._themes.optimizeDarkLight) this.optimizeTransition.darkModeTransition?.run();
          this._timeouts.transition = 0;
          return GLib.SOURCE_REMOVE;
        })

All Versions

Version Status
1.0.0 (13) Unreviewed
1.0.0 (12) Rejected
1.0.0 (11) Rejected
1.0.0 (10) Rejected
1.0.5 (9) Rejected
1.0.5 (8) Rejected
1.0.4 (7) Rejected
1.0.3 (6) Rejected
1.0.2 (5) Rejected
1.0.1 (4) Rejected
1.0.0 (3) Rejected
1.0.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

Pedro Henrique auto- rejected
Auto-rejected because of new version 1.0.4 (7) was uploaded