Review of "DayNight Theme Sync" version 1.0.4 (7)

Details Page Preview

Automatically change theme styles when dark mode is enabled or disabled.

Extension Homepage
https://github.com/phenrique-coder/DayNight-Theme-Sync

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.0.0 (13) Unreviewed
1.0.0 (12) Rejected
1.0.0 (11) Rejected
1.0.0 (10) Rejected
1.0.5 (9) Rejected
1.0.5 (8) Rejected
1.0.4 (7) Rejected
1.0.3 (6) Rejected
1.0.2 (5) Rejected
1.0.1 (4) Rejected
1.0.0 (3) Rejected
1.0.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed before creating a new one (line 140 `others/darkLightSwitch.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Please remove line 95 `others/darkLightSwitch.js` since that falls under selective disable. 3. Can be approved but better remove the timeout id in the loop (line 93-96 `extension.js`).