Review of "Accent Hold" version 2

Details Page Preview

Hold a letter (e, a, c, o, n…) and pick its accented variant (é è ê ë, ç, ñ, ô…) from a popup, with its number, the arrows or the mouse; a quick tap types the letter as usual. Works on any keyboard layout, without a daemon or root, in applications that use the GNOME input method (Wayland: GTK, VTE terminals, Electron with its Wayland backend). A shortcut (Super+E by default) opens the same picker without holding. Preferences: press-and-hold on/off and duration, shortcut, character table, keyboard layouts.

Extension Homepage
https://github.com/d101c/accent-hold

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • accentPicker.js:280
    St.Clipboard.get_default()
  • accentPicker.js:303
    St.Clipboard.get_default()

All Versions

Version Status
2.4 (9) Active
2.3 (8) Active
2.2 (7) Rejected
2.1 (6) Active
2.1 (5) Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. That is the instance, not the function (line 15 `accentPicker.js`). It should be called `settings` not `getSettings`. And you are actually wrongly doing `this._getSettings()` in that file. 4. Remove unnecessary try-catch wrappers around settings get. 5. Timeout should be removed before creating a new one (line 113, 300 `accentPicker.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions