Review of "Accent Hold" version 2.2 (7)

Details Page Preview

Hold a letter (e, a, c, o, n…) and pick its accented variant (é è ê ë, ç, ñ, ô…) from a popup, with its number, the arrows or the mouse; a quick tap types the letter as usual. Works on any keyboard layout, without a daemon or root, in applications that use the GNOME input method (Wayland: GTK, VTE terminals, Electron with its Wayland backend). A shortcut (Super+E by default) opens the same picker without holding. Preferences: press-and-hold on/off and duration, shortcut, character table, keyboard layouts.

Extension Homepage
https://github.com/d101c/accent-hold

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
2.4 (9) Active
2.3 (8) Active
2.2 (7) Rejected
2.1 (6) Active
2.1 (5) Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

jg__ posted a review
2.2 is a maintenance release after an independent code review of 2.1. Changes a reviewer may want to know about: the shortcut picker no longer uses the clipboard at all (it commits through the shell input method, and the clipboard declaration is gone from the description); the keybinding key is namespaced (accent-hold-shortcut, old value migrated once); the IBus prototype wrapper is only installed while press-and-hold is on and is restored only if it is still ours, so it coexists with other extensions patching the same method; both popups are clamped to the monitor; Space and Enter dismiss instead of inserting an accent; key repeat on the client side is handled by forwarding the release of the held letter when the popup opens. 54 unit tests run with plain gjs (extension/tests/run.sh in the repository). As before: I used AI assistance to write and review this code and can explain every line.
jg__ auto- rejected
Auto-rejected because of new version 2.3 (8) was uploaded