Review of "Accent Hold" version 2.1 (5)

Details Page Preview

Hold a letter (e, a, c, o, n…) and pick its accented variant (é è ê ë, ç, ñ, ô…) from a popup, with its number, the arrows or the mouse; a quick tap types the letter as usual. Works on any keyboard layout, without a daemon or root, in applications that use the GNOME input method (Wayland: GTK, VTE terminals, Electron with its Wayland backend). A shortcut (Super+E by default) opens the same picker without holding. Preferences: press-and-hold on/off and duration, shortcut, character table, keyboard layouts.

Extension Homepage
https://github.com/d101c/accent-hold

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • accentPicker.js:267
    St.Clipboard.get_default()
  • accentPicker.js:287
    St.Clipboard.get_default()

All Versions

Version Status
2.4 (9) Active
2.3 (8) Active
2.2 (7) Rejected
2.1 (6) Active
2.1 (5) Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

jg__ posted a review
Version 2.1 adds press and hold. pressHold.js wraps IBus.InputContext.process_key_event_async/_finish (restored in destroy()) to watch the keys GNOME Shell's input method already forwards. Keys pass through unchanged except digits/arrows/Enter/Esc while the variants popup is shown. No main-loop source outlives disable(). The clipboard use flagged by Shexli is the existing Super+E picker, unchanged and described in the description.
JustPerfection rejected
Timeout in `pressHold.js` should be removed on destroy: [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)
JustPerfection posted a review
* All timeouts in `pressHold.js`