Review of "Todoit" version 8

Details Page Preview

Simple todo list, to keep you focused on your daily tasks

Extension Homepage
https://github.com/wassimbj/todoit-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:177
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:280
            draggable.connect("drag-begin", () => {
                item.add_style_class_name("dragging");
                return true;
            })
  • extension.js:284
            draggable.connect("drag-end", () => {
                // Source row is still alive here (UI rebuild is deferred until after drop)
                item.remove_style_class_name("dragging");
                this._clearDragOver();
                if (this._pendingRepopulate) {
                    this._pendingRepop
  • extension.js:69
            this.input.clutterText.connect("activate", (source) => {
                let taskText = source.get_text().trim();
                if (taskText) {
                    this._addTask(taskText);
                    source.set_text("");
                    source.grab_key_focus();
                }
            })

All Versions

Version Status
8 Active
7 Active
6 Active
5 Active
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active