Review of "Todoit" version 7

Details Page Preview

Simple todo list, to keep you focused on your daily tasks

Extension Homepage
https://github.com/wassimbj/todoit-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:167
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:65
            this.input.clutterText.connect("activate", (source) => {
                let taskText = source.get_text().trim();
                if (taskText) {
                    this._addTask(taskText);
                    source.set_text("");
                    source.grab_key_focus();
                }
            })

All Versions

Version Status
7 Active
6 Active
5 Active
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

fmuellner active
The shexli warning about build artifacts (namely gschemas.compiled) would be worth addressing. (The clipboard usage is fine, and the other warning looks like a false-positive)