Review of "ntfy Indicator" version 1

Details Page Preview

Desktop notifications via ntfy - Subscribe to channels and receive real-time notifications

Extension Homepage
https://github.com/rghvdberg/ntfy-indicator

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51', '52']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:27
      getPreferencesWidget() {
        this.settings = this.getSettings();
    
        const page = new Adw.PreferencesPage({
          title: 'General',
          icon_name: 'preferences-system-symbolic'
        });
    
        this._currentPage = page;
    
        page.add(this._createServerGroup());
        page.add(this._createSubscription

All Versions

Version Status
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove the xml file from the root. 2. Remove 51 and 52 since we don't have those yet. 3. Fix issues mentioned in shexli. 4. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 5. All files not included. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions