Desktop notifications via ntfy - Subscribe to channels and receive real-time notifications
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 6 | Unreviewed |
| 5 | Rejected |
| 4 | Rejected |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
ignore this, I just found a bug
1. Timeout should be removed on destroy and before creating a new one (line 88, 99 `api.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) It's better to create a destroy function for that class and remove all the timeout ids there. 2. You should call `abort()` on disable or destroy: - line 29 `api.js` - line 68 `attachment-downloader.js` [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 3. You cannot create instance of objects in global scope: - line 153 `attachment-downloader.js` - line 211 `notification-store.js` - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. `this._destroyed` is a bad practice. Please remove that: [Extension Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html) 5. Remove unnecessary try catch wrappers: [Extension Best Practices Guidelines: Unnecessary try-catch](https://gjs.guide/extensions/review-guidelines/best-practices.html#avoid-unnecessary-try-catch-wrappers) 6. I recommend to use d-bus for this. You can create an app that do everything outside of extension and use that app as a dependency of this extension. Then, your extension can communicate between that app and this extension: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions