Review of "ntfy Indicator" version 5

Details Page Preview

Desktop notifications via ntfy - Subscribe to channels and receive real-time notifications

Extension Homepage
https://github.com/rghvdberg/ntfy-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • history-dialog.js

All Versions

Version Status
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Why there is a function inside a method (line 226 `api.js`). 2. I cannot trace back where the timeout is getting removed on destroy/disable (line 229 `api.js`). 3. You cannot create instance of objects in global scope: - line 208 `attachment-downloader.js` - line 312 `notification-store.js` - line 500 `subscription-manager.js` - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Use icons instead of emjoi: [Extension Best Practices Guidelines: Icons vs. Emojis](https://gjs.guide/extensions/review-guidelines/best-practices.html#ui-elements-icons-vs-emojis) 5. D-Bus interface name should start with `org.gnome.Shell.Extensions` (line 32-33 `subscription-manager.js`).