Review of "Widgets" version 0.2.0 (2)

Details Page Preview

Desktop widgets: clock, calendar, weather, photos, and battery.

Extension Homepage
https://github.com/TheRealSourcer/widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
0.2.2 (4) Active
0.2.1 (3) Active
0.2.0 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Not needed to use line 119 `extension.js`. for example, this is how you can get GNOME settings with no issues: ```js new Gio.Settings({schema_id: 'org.gnome.desktop.background'}); ``` 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` process only). 3. better to use `destroy` function directly: [Extension Best Practices Guidelines: Widget Destruction vs. Signal Connections](https://gjs.guide/extensions/review-guidelines/best-practices.html#widget-destruction-vs-signal-connections) 4. Please remove `showcase.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files)