Review of "Widgets" version 0.3.0 (7)

Details Page Preview

Desktop widgets: clock, calendar, weather, photos, and more.

Extension Homepage
https://github.com/TheRealSourcer/widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
0.3.0 (10) Active
0.3.0 (9) Rejected
0.3.0 (8) Active
0.3.0 (7) Rejected
0.3.0 (6) Rejected
0.2.3 (5) Active
0.2.2 (4) Inactive
0.2.1 (3) Inactive
0.2.0 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove try-catch from enable. 2. Remove line 45 `extension.js`. It's not really needed and it makes it selective disable in racy situations. 3. Timeout should be removed before creating a new one: - line 303 `widgets/battery/widget.js` - line 56 `widgets/weather/widget.js` - line 246 `utils/screenTimeEngine.js` - line 839 `widgets/github/widget.js` 4. Remove the check (line 49 `widgets/calendar/widget.js`): https://gjs.guide/extensions/review-guidelines/best-practices.html#avoid-unnecessary-checks 5. Selective disable isn't allowed: - line 34 `desktop/controller.js` - line 88 `gallery/drag.js` - line 552 `widgetGallery.js` - line 424 `widgets/applauncher/widget.js` - line 657 `widgets/events/widget.js` - line 760 `widgets/music/controller.js` - line 466 `widgets/stocks/widget.js` 6. Remove line 192 `desktop/editor.js`. Also connect with `this` so you can disconnect object with `this`. 7. Remove version from the import (line 5 `widgets/stocks/widget.js`).