Review of "Frippery Panel Favorites" version 55

Details Page Preview

Add launchers for Favorites to the panel

Extension Homepage
https://frippery.org/extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 5

Shexli found 6 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:52
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:52
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • extension.js:32
            this.actor = new St.Button({ style_class: 'panel-button',
                                         reactive: true })
  • extension.js:44
    this.label = new St.Label({ style_class: 'panel-launcher-label'})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:56
            this.actor.connect('button-press-event',
                    this._onButtonPress.bind(this))
  • extension.js:54
            this.actor.connect('notify::hover',
                    this._onHoverChanged.bind(this))
  • extension.js:262
                launcher.actor.connect('notify::hover',
                            () => this._onHover(launcher))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['49', '50', '51']

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:296
        getPreferencesWidget() {
            return new PanelFavoritesSettingsWidget(this.getSettings());
        }

All Versions

Version Status
55 Active
54 Active
53 Active
52 Active
51 Active
50 Active
49 Active
48 Rejected
47 Active
46 Rejected
45 Active
44 Active
43 Active
42 Rejected
41 Active
40 Inactive
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active