Review of "Gnoming Profiles" version 10

Details Page Preview

Sync gsettings and user config files to GitHub, Nextcloud, or Google Drive with binary-safe wallpaper syncing and ETag-based polling

Extension Homepage
https://github.com/gavindi/gnoming-profiles

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 7

Shexli found 8 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • extension.js:283
    this._sessionManager.run_dispose()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:263
    console.error(`Failed to setup session handlers: ${e.message}`)
  • extension.js:275
    console.error(`Error disconnecting session manager signal: ${e.message}`)
  • extension.js:285
    console.error(`Error cleaning up session manager proxy: ${e.message}`)
  • extension.js:427
    console.error(`${this._storageProvider.name} initial poll error: ${error.message}`)
  • extension.js:460
    console.error(`${this._storageProvider.name} ETag polling error: ${error.message}`)
  • extension.js:508
    console.error(`${this._storageProvider.name} polling error: ${error.message}`)
  • extension.js:686
    console.error(`Cannot perform sync operation: components not initialized`)
  • extension.js:706
    console.error(`Sync operation failed: ${operationType} - ${error.message}`)
  • extension.js:827
    console.error(`Failed to open preferences: ${error.message}`)
  • extension.js:35
    console.log(`GnomingProfiles: Google Drive provider unavailable (GOA not installed): ${e.message}`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/GoogleDriveProvider.js:93
    console.error(`GoogleDriveProvider: Failed to get GOA credentials: ${e.message}`)
  • lib/GoogleDriveProvider.js:149
    console.error(`GoogleDriveProvider: Failed to enumerate GOA accounts: ${e.message}`)
  • lib/GoogleDriveProvider.js:417
    console.error(`GoogleDriveProvider: Failed to update ${change.path}: HTTP ${response.status}`)
  • lib/GoogleDriveProvider.js:441
    console.error(`GoogleDriveProvider: Failed to create ${change.path}: HTTP ${response.status}`)
  • lib/GoogleDriveProvider.js:445
    console.error(`GoogleDriveProvider: Error uploading ${change.path}: ${e.message}`)
  • lib/GoogleDriveProvider.js:455
    console.error(`GoogleDriveProvider: File not found: ${path}`)
  • lib/GoogleDriveProvider.js:467
    console.error(`GoogleDriveProvider: Download failed for ${path}: HTTP ${response.status}`)
  • lib/NextcloudProvider.js:207
    console.error(`NextcloudProvider: Root folder MKCOL returned ${response.status}`)
  • lib/NextcloudProvider.js:208
    console.error(`NextcloudProvider: Response: ${String(response.data).substring(0, 500)}`)
  • lib/NextcloudProvider.js:257
    console.error(`NextcloudProvider: Failed to upload ${change.path}: HTTP ${response.status}`)
  • lib/NextcloudProvider.js:258
    console.error(`NextcloudProvider: Response: ${String(response.data).substring(0, 500)}`)
  • lib/NextcloudProvider.js:261
    console.error(`NextcloudProvider: Error uploading ${change.path}: ${e.message}`)
  • lib/NextcloudProvider.js:276
    console.error(`NextcloudProvider: Download failed for ${path}: HTTP ${response.status}`)
  • lib/NextcloudProvider.js:277
    console.error(`NextcloudProvider: Response: ${String(response.data).substring(0, 500)}`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/SyncManager.js:451
    file.load_contents(null)
  • lib/WallpaperManager.js:147
    file.load_contents(null)
  • lib/WallpaperManager.js:312
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 14 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/SyncManager.js:83
    console.error(`Sync Manager: Operation failed: ${operationType} - ${error.message}`)
  • lib/SyncManager.js:116
    console.error(`Sync Manager: Queued operation failed: ${nextOperation.operationType} - ${error.message}`)
  • lib/SyncManager.js:194
    console.error(`Sync Manager: Failed to backup ${schema}.${key}: ${e.message}`)
  • lib/SyncManager.js:204
    console.error(`Sync Manager: Failed to access schema ${schema}: ${e.message}`)
  • lib/SyncManager.js:208
    console.error(`Sync Manager: Critical error during backup: ${e.message}`)
  • lib/SyncManager.js:286
    console.error(`Sync Manager: Failed to restore ${schema}.${key}: ${e.message}`)
  • lib/SyncManager.js:291
    console.error(`Sync Manager: Failed to access schema ${schema} for restore: ${e.message}`)
  • lib/SyncManager.js:366
    console.error(`Sync Manager: Failed to sync to ${this.storageProvider.name}: ${error.message}`)
  • lib/SyncManager.js:401
    console.error(`Sync Manager: Failed to sync from ${this.storageProvider.name}: ${error.message}`)
  • lib/SyncManager.js:453
    console.error(`Sync Manager: Failed to read file ${original}`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/WallpaperManager.js:123
    console.error(`Wallpaper Manager: Failed to track wallpaper ${schema}.${key}: ${e.message}`)
  • lib/WallpaperManager.js:150
    console.error(`Wallpaper Manager: Failed to read wallpaper content: ${wallpaperData.filePath}`)
  • lib/WallpaperManager.js:156
    console.error(`Wallpaper Manager: Wallpaper file is empty: ${wallpaperData.filePath}`)
  • lib/WallpaperManager.js:169
    console.error(`Wallpaper Manager: Error reading wallpaper ${wallpaperKey}: ${e.message}`)
  • lib/WallpaperManager.js:215
    console.error(`Wallpaper Manager: Failed to download wallpaper ${fileInfo.name}: ${e.message}`)
  • lib/WallpaperManager.js:220
    console.error(`Wallpaper Manager: Failed to download wallpapers: ${error.message}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['47', '48', '49', '50', '51']

All Versions

Version Status
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active