Review of "Mute/Unmute" version 23

Details Page Preview

This extension allows muting/unmuting volume output/input by middle-clicking the speaker/mic icon on the menu bar. This extension uses mute/unmute API in order to restore previous volume level after unmuting. For Gnome 43 and previous versions it supports only muting/unmuting volume output but it adds also the same behaviour of Gnome 44 and later versions: mute/unmute audio by clicking the audio output icon next to the volume slider

Extension Homepage
https://github.com/ihpled/mute-unmute

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:63
              this._volume_input_event_id = this._volumeInput.connect(
                'button-press-event',
                (actor, event) => {
                  if (event.get_button() === Clutter.BUTTON_MIDDLE) {
                    this._toggleInputMuted();
                    return Clutter.EVENT_STOP;
                  }
    
  • extension.js:46
              this._volume_output_event_id = this._volumeOutput.connect(
                'button-press-event',
                (actor, event) => {
                  if (event.get_button() === Clutter.BUTTON_MIDDLE) {
                    this._toggleOutputMuted();
                    return Clutter.EVENT_STOP;
                 

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:36
    this._initTimeout = setTimeout(() => {this._doInit()}, 1000)

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active