Review of "Keylightd Control" version 8

Details Page Preview

Control keylightd via the GNOME Shell Quick Settings menu.

Extension Homepage
https://github.com/jmylchreest/keylightd

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 14 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:274
            console.error(
              "Error refreshing groups during background refresh:",
              groupError,
            )
  • extension.js:285
            console.error(
              "Error refreshing lights during background refresh:",
              lightError,
            )
  • extension.js:336
                console.error(
                  "Error updating toggle state during background refresh:",
                  toggleError,
                )
  • extension.js:346
                console.error(
                  "Error updating indicator visibility during background refresh:",
                  indicatorError,
                )
  • extension.js:354
    console.error("Error during background refresh:", error)
  • extension.js:378
    console.error(`Error opening preferences: ${error}`)
  • extension.js:393
    console.error("Error during initial refresh:", error)
  • extension.js:406
    console.error("Error refreshing groups:", groupError)
  • extension.js:413
    console.error("Error refreshing lights:", lightError)
  • extension.js:421
    console.error("Error updating indicator visibility:", indicatorError)

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

GdH active