Review of "Frippery Bottom Panel" version 84

Details Page Preview

Add a bottom panel to the shell

Extension Homepage
http://frippery.org/extensions

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:378
            this.actor = new St.BoxLayout({
                                style_class: 'window-list-item-box',
                                reactive: true,
                                track_hover: true})
  • extension.js:391
            this.label = new St.Label({
                                style_class: 'window-list-item-label',
                                y_align: Clutter.ActorAlign.CENTER})
  • extension.js:591
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • extension.js:568
            this.actor = new St.BoxLayout({
                                name: 'windowList',
                                x_expand: true,
                                style_class: 'window-list-box' })
  • extension.js:772
            this.actor = new St.Bin({ style_class: 'toggle-switch',
                                      accessible_role: Atk.Role.CHECK_BOX,
                                      can_focus: true })
  • extension.js:1023
            this.actor = new St.Button({ name: 'workspaceButton',
                                     style_class: 'workspace-button',
                                     reactive: true })
  • extension.js:1029
            this.label = new St.Label({
                                x_align: Clutter.ActorAlign.CENTER,
                                y_align: Clutter.ActorAlign.CENTER})
  • extension.js:1084
            this.actor = new St.BoxLayout({ name: 'workspaceSwitcher',
                                            style_class: 'frippery-ws-switcher',
                                            reactive: true })
  • extension.js:1113
                this.row_indicator = new St.DrawingArea({ reactive: true,
                                        style_class: 'workspace-row-indicator' })
  • extension.js:1286
            this.actor = new St.BoxLayout({ style_class: 'bottom-panel',
                                            name: 'bottomPanel',
                                            reactive: true })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:1524
    this._workspaceSwitcherPopup = new FripperySwitcherPopup()
  • extension.js:378
            this.actor = new St.BoxLayout({
                                style_class: 'window-list-item-box',
                                reactive: true,
                                track_hover: true})
  • extension.js:391
            this.label = new St.Label({
                                style_class: 'window-list-item-label',
                                y_align: Clutter.ActorAlign.CENTER})
  • extension.js:591
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • extension.js:568
            this.actor = new St.BoxLayout({
                                name: 'windowList',
                                x_expand: true,
                                style_class: 'window-list-box' })
  • extension.js:772
            this.actor = new St.Bin({ style_class: 'toggle-switch',
                                      accessible_role: Atk.Role.CHECK_BOX,
                                      can_focus: true })
  • extension.js:836
    this._settings = new Gio.Settings({ schema: MUTTER_SCHEMA })
  • extension.js:879
    this.wm_settings = new Gio.Settings({ schema: WM_SCHEMA })
  • extension.js:1023
            this.actor = new St.Button({ name: 'workspaceButton',
                                     style_class: 'workspace-button',
                                     reactive: true })
  • extension.js:1029
            this.label = new St.Label({
                                x_align: Clutter.ActorAlign.CENTER,
                                y_align: Clutter.ActorAlign.CENTER})
  • extension.js:1034
    this.tooltip = new St.Label({ style_class: 'bottom-panel-tooltip'})
  • extension.js:1093
    this._settings = new Gio.Settings({ schema: MUTTER_SCHEMA })
  • extension.js:1084
            this.actor = new St.BoxLayout({ name: 'workspaceSwitcher',
                                            style_class: 'frippery-ws-switcher',
                                            reactive: true })
  • extension.js:1113
                this.row_indicator = new St.DrawingArea({ reactive: true,
                                        style_class: 'workspace-row-indicator' })
  • extension.js:1286
            this.actor = new St.BoxLayout({ style_class: 'bottom-panel',
                                            name: 'bottomPanel',
                                            reactive: true })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1525
                            this._workspaceSwitcherPopup.connect('destroy', () => {
                                this._workspaceTracker.unblockUpdates();
                                this._workspaceSwitcherPopup = null;
                                this._isWorkspacePrepended = false;
                          
  • extension.js:414
            this.actor.connect('button-press-event',
                                        this._onButtonPress.bind(this))
  • extension.js:416
            this.actor.connect('button-release-event',
                                        this._onButtonRelease.bind(this))
  • extension.js:413
    this.actor.connect('destroy', this._onDestroy.bind(this))
  • extension.js:418
            this.actor.connect('notify::allocation',
                                        this._updateIconGeometry.bind(this))
  • extension.js:594
    this.actor.connect('destroy', this._onDestroy.bind(this))
  • extension.js:800
            this.actor.connect('button-release-event',
                    this._onButtonReleaseEvent.bind(this))
  • extension.js:803
    this.actor.connect('key-focus-in', this._onKeyFocusIn.bind(this))
  • extension.js:804
    this.actor.connect('key-focus-out', this._onKeyFocusOut.bind(this))
  • extension.js:802
    this.actor.connect('key-press-event', this._onKeyPressEvent.bind(this))
  • extension.js:1026
    this.actor.connect('clicked', this._onClicked.bind(this))
  • extension.js:1027
    this.actor.connect('destroy', this._onDestroy.bind(this))
  • extension.js:1087
    this.actor.connect('button-release-event', this._showDialog)
  • extension.js:1089
    this.actor.connect('destroy', this._onDestroy.bind(this))
  • extension.js:1088
    this.actor.connect('scroll-event', this._onScroll)
  • extension.js:1131
    btn.actor.connect('notify::hover', () => this._onHover(btn))
  • extension.js:1116
                this.row_indicator.connect('button-press-event',
                                        this._rowButtonPress.bind(this))
  • extension.js:1115
    this.row_indicator.connect('repaint', this._draw.bind(this))
  • extension.js:1118
                this.row_indicator.connect('scroll-event',
                                        this._rowScroll.bind(this))
  • extension.js:1303
    this.actor.connect('destroy', this._onDestroy.bind(this))
  • extension.js:1302
    this.actor.connect('style-changed', this.relayout.bind(this))

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:148
        getPreferencesWidget() {
            return new BottomPanelSettingsWidget(this.getSettings());
        }

All Versions

Version Status
84 Unreviewed
83 Active
82 Active
81 Rejected
80 Rejected
79 Active
78 Active
77 Rejected
76 Active
75 Inactive
74 Active
73 Active
72 Active
71 Active
70 Active
69 Active
68 Active
67 Active
66 Active
65 Rejected
64 Active
63 Active
62 Active
61 Active
60 Active
59 Active
58 Active
57 Rejected
56 Rejected
55 Active
54 Rejected
53 Active
52 Active
51 Active
50 Inactive
49 Active
48 Active
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Active
39 Rejected
38 Rejected
37 Active
36 Rejected
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Active
2 Active
1 Active