Review of "Maximus" version 3

Details Page Preview

NOTE: not maintained (by me) since 3.8 or so, looking for new maintainers! Contact me through the repo. You may have some luck with changing the version in 'metadata.json' to your gnome-shell version. Undecorate maximized windows, like Ubuntu's old 'Maximus' package. See readme at extension homepage.

Extension Homepage
https://bitbucket.org/mathematicalcoffee/maximus-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Inactive
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

mathematical.coffee posted a review
Please ignore v2, I uploaded the wrong version by accident.
Jasper St. Pierre posted a review
You do know about _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED, right? You could set that on all windows from window-added.
mathematical.coffee posted a review
Yes, but I couldn't find a way to convert a winActor into a GTK window in order to set the hint, and when I asked on the mailing list the answer was "No you can't". I'd be happy to try if I only knew how.
mathematical.coffee posted a review
Furthermore, Gtk's set_hide_titlebar_when_maximised is not exposed (well, not in the Gtk-3.0 gir anyhow)
Jasper St. Pierre posted a review
You don't need a GTK+ window. You can fork out to xprop like you do for MWM.
mathematical.coffee posted a review
Oh, I see. Thanks! However, I can't seem to get it to work? From the mutter/gtk source I understand this to be a 32bit cardinal so: xprop -id 0x1e00004 -f _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 32c -set '_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED' '0x1' This sets the hint fine and I can check it back via xprop: xprop -id 0x1e00004 | grep GTK _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED(CARDINAL) = 1 However, the window decoration does not get hidden when I maximise - it looks like the window manager is not paying attention to the hint? As far as I can tell, I am also using the right window ID - the same I would set the _MOTIF_WM_HINTS hint on. Am I not setting the property to the right value or something?
Jasper St. Pierre posted a review
I deleted the -id part, ran it, clicked on a window, and it worked for me.
mathematical.coffee posted a review
Hmm, still not for me. Would this be something that works in (say) GNOME 3.4 and not 3.2? (I am on 3.2 at the moment, won't be able to test 3.4 until I get home).
Jasper St. Pierre posted a review
The hiding titlebar feature is new to 3.4, yes.
mathematical.coffee posted a review
OK. Why don't I leave the current version of extension as-is (its metadata.json is still correct), and then write a 3.4-only version that uses _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED ? So that 3.2 folk will get this one (and they can choose to use it in 3.4 if they wish), and 3.4 folk will get this version?
mathematical.coffee posted a review
3.4 folk will get *the new* version**
Jasper St. Pierre posted a review
Yeah, that's fine.
mathematical.coffee posted a review
You are using the command as I have above minus the '-id ....' right? xprop -f _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED 32c -set '_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED' '0x1' And then click on a window? This is still not working for me in gnome 3.4.
Jasper St. Pierre posted a review
http://magcius.mecheye.net/shell/maximus.webm
mathematical.coffee posted a review
Aha! I'm using the Ambiance metacity theme on Ubuntu which is what was set by default (I've had that since install) - it doesn't work there. If I switch to Adwaita it works... Similarly going through the metacity themes that came with my install, some work and some (in particular Radiance & Ambiance, the ubuntu ones) don't. Should I press ahead with this version of the extension anyway with the caveat that if it doesn't work, users have to select a different metacity theme? The _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED does seem *way* more stable than the current "wait for them to maximize a window and then jump in"...