Review of "Maximus" version 4

Details Page Preview

NOTE: not maintained (by me) since 3.8 or so, looking for new maintainers! Contact me through the repo. You may have some luck with changing the version in 'metadata.json' to your gnome-shell version. Undecorate maximized windows, like Ubuntu's old 'Maximus' package. See readme at extension homepage.

Extension Homepage
https://bitbucket.org/mathematicalcoffee/maximus-gnome-shell-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
9 Inactive
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

mathematical.coffee posted a review
Main changes - * added whitelists/blacklists * code reorganisation: the functions 'decorate', 'undecorate', and 'guessWindowXID' do all the work. The other functions onMaximise and onUnmaximise just call these (just for clearer reading). * Since maximised windows have no titlebar, users will often "drag" the window to try unmaximise/move it. I noticed that sometimes Metacity regards this as a request to fullscreen the application. For applications like thunderbird that don't actually support fullscreen (i.e. have no toggle for it), it's really easy to get "stuck" in fullscreen mode. To work around it we do Meta.prefs_set_force_fullscreen(false); to disable this behaviour. (I will look at setting _GDK_HIDE_TITLEBAR_WHEN_MAXIMIZED but this doesn't work on all window themes, in particular the Ubuntu ones (which don't seem to respect it??), making this solution unviable for now). * guessWindowXID: tried to make it more robust with respect to frameless windows (in which case the window actor's 'x-window' property is the X ID we're after, as opposed to the X ID of the child of that window).
gcampax posted a review
Uhm... ok