Review "Snowy" version 1 - GNOME Shell Extensions

Review of "Snowy" version 1

Details Page Preview

Snowy

Let it snow! - GNOME 46 support - Multiple monitors support - GUI preferences - Animation configuration - Fully customizable appearance

Extension Homepage: https://github.com/ExposedCat/snowy

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
24	Active
23	Active
22	Active
21	Active
20	Rejected
19	Rejected
18	Rejected
17	Rejected
16	Active
15	Active
14	Active
13	Rejected
12	Active
11	Inactive
10	Inactive
9	Rejected
8	Rejected
7	Active
6	Inactive
5	Inactive
4	Inactive
3	Rejected
2	Inactive
1	Rejected

Previous Reviews on this Version

andyholmes rejected December 16, 2020

You should be returning `false` or `GLib.SOURCE_REMOVE` from your mainloop source to remove it. Currently your extension never removes the mainloop source when disabled because `return func.apply(this) || true;` will always return `true`. Please fix this so your extension can be approved. See: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review You also probably want to consider using Clutter's implicit animations instead of Tweener to lower CPU usage.

Artem Prokop posted a review December 22, 2020

Analogue to GLib.timeout_add ?