Review of "Snowy" version 18

Details Page Preview

Let it snow! - GNOME 49 support - Multiple monitors support - GUI preferences - Animation configuration - Fully customizable appearance

Extension Homepage
https://github.com/ExposedCat/snowy

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed on disable (line 8 js/utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
JustPerfection posted a review
btw, I understand you are storing it in `this.timerId` by `onRecreated` (line 66 js/manager.js) but returning the source id by `setInterval()` would be much better. and when you call `setInterval()` again (line 11 js/utils.js), that can cause an infinite loop. In that case, `onRecreated` receives the latest source id without removing the previous one.
Artem Prokop posted a review
I do it that way with `onRecreacted` because I re-create timeouts recursively. Manager will receive only first timeout id and that it will be changed. I think the issue can be fixed just by adding `GLib.Source.remove` before re-creation. The reason I'm doing all that is because I need a dynamic timeout
Artem Prokop posted a review
I do it that way with `onRecreacted` because I re-create timeouts recursively. Manager will receive only first timeout id and that it will be changed. I think the issue can be fixed just by adding `GLib.Source.remove` before re-creation. The reason I'm doing all that is because I need a dynamic timeout