Review of "Snowy" version 5

Details Page Preview

Let it snow! - GNOME 46 support - Multiple monitors support - GUI preferences - Animation configuration - Fully customizable appearance

Extension Homepage
https://github.com/ExposedCat/snowy

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Active
20 Rejected
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

Artem Prokop auto- active
JustPerfection posted a review
Not going to reject this one since the code was there from the old versions but you should remove the timeout in disable (extension.js line 72): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources
Artem Prokop posted a review
@JustPerfection GLib.SOURCE_REMOVE does the thing, doesn't it?
JustPerfection posted a review
As mentioned in the review guidelines: > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. It's because the timeout can be called in lock screen when the extension is disabled (in racy situations or in case we have unwanted additional delay).