Review of "TwitchLive Panel" version 36

Details Page Preview

A panel showing whether your favorite Twitch.tv streamers are streaming. Cycles through the online streamers if multiples are configured. Click on the panel and then on streamer's name to launch the stream with a custom command (your browser or some other application). Needs curl and mogrify to fully support streamer logos.

Extension Homepage
https://github.com/maweki/twitchlive-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
44 Active
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

maweki auto- active
JustPerfection posted a review
Hey, 1. You cannot create objects in init function and global scope (same as init). Line 40-46, 403-411 (extension.js) needs to be moved to enable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. For the comment on Line 405-406: Probably happens because you are creating objects in init() function. Moving those lines to enable may solve the issue. 3. Please remove .jshintrc, .po and .pot files for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 4. Just a recommendation: Since the extension supports 3.14 to 3.24, you may want to drop those 3.x versions and only support 4x.x versions. I'm saying that because you are not supporting 3.36 which is the most used 3.x version today (Ubuntu 20.04). Multi versioning is also supported here. 5. If you dropped 3.x versions, Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js These functions are supported since 3.34 You can find us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions