Review of "Adjust Display Brightness" version 1

Details Page Preview

Simple GNOME extension to control displays' brightness via DDC. It requires ddcutil to be installed, I2C permissions for non-root users configured.

Extension Homepage
https://gitlab.com/bruno.englert/gnome-extension-brightness

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. The timeout in line 75 `ui/SliderMenuItem.js` should be removed on disable. You may want to remove that on object destroy which is getting triggered from `MainBrightnessSliderItem`. 2. Remove Lang import in `ui/ScreenBrightnessPanelMenu.js`. 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extension