Review "Adjust Display Brightness" version 1

Review of "Adjust Display Brightness" version 1

Details Page Preview

Adjust Display Brightness

Simple GNOME extension to control displays' brightness via DDC. It requires ddcutil to be installed, I2C permissions for non-root users configured.

Extension Homepage: https://gitlab.com/bruno.englert/gnome-extension-brightness

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
28	Rejected
27	Active
26	Inactive
25	Inactive
24	Inactive
23	Inactive
22	Inactive
21	Inactive
20	Inactive
19	Inactive
18	Inactive
17	Inactive
16	Inactive
15	Inactive
14	Inactive
13	Inactive
12	Inactive
11	Inactive
10	Inactive
9	Inactive
8	Inactive
7	Rejected
6	Rejected
5	Inactive
4	Inactive
3	Inactive
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected December 7, 2021

1. The timeout in line 75 `ui/SliderMenuItem.js` should be removed on disable. You may want to remove that on object destroy which is getting triggered from `MainBrightnessSliderItem`. 2. Remove Lang import in `ui/ScreenBrightnessPanelMenu.js`. 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extension