Review of "Adjust Display Brightness" version 5

Details Page Preview

Simple GNOME extension to control displays' brightness via DDC. It requires ddcutil to be installed, I2C permissions for non-root users configured.

Extension Homepage
https://gitlab.com/bruno.englert/gnome-extension-brightness

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging Please remove them for the next version.
Ghost posted a review
These logs are checking if the init run without any issues, but after the init, there is not much logging. There have been already bug reports, and without logs, I can't really solve bug reports.
Ghost posted a review
These logs are checking if the init run without any issues, but after the init, there is not much logging. There have been already bug reports, and without logs, I can't really solve bug reports.
JustPerfection posted a review
You can have `"debug" : false` in metadata.json and those users can change it to true when facing issues (they need to restart GNOME Shell after changing the metadata though). btw, you are logging spawn outputs. That's not a good practice. Should only happen in debug mode.