Review of "Audio Output Switcher" version 18

Details Page Preview

Adds a switch for choosing audio output to the system menu.

Extension Homepage
http://github.com/adaxi/audio-output-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
It's ok now but what is the reason for BSD 2-Clause License? Since you are adding something to GNOME Shell, it means the license should be GPLv2 or later. Picking another license is more appropriate for the things out of GNOME Shell scope. For example, a gtk app shipping with extension (app can be in other license but the code touching GNOME Shell should be GPLv2 or later).
adaxi posted a review
That is the license under which the original creator of the extension licensed the shell extension: https://github.com/anduchs/audio-output-switcher/blob/master/LICENSE
JustPerfection active
Ok I approve this one but please note your code and all the older versions are still under GPLv2 or later as stated in Review Guidelines: > While your extension may include code licensed under a permissive license such as BSD/MIT, > you are still approving GNOME to distribute it under terms compatible with the GPL-2.0-or-later. https://gjs.guide/extensions/review-guidelines/review-guidelines.html#licensing If you have any question you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
adaxi posted a review
Yes, indeed I agreed the terms where I approve GNOME to distribute it under terms compatible with the GPL-2.0-or-later.