Review of "Bing Wallpaper" version 38

Details Page Preview

Sync your wallpaper to today's Microsoft Bing image of the day (the image you see when you visit Bing.com). *Disclaimer*: this extension is unofficial and not affiliated with Bing or Microsoft in any way. Images are protected by copyright and are licensed only for use as wallpapers. Features: * UHD resolution wallpapers * Automatically fetches current Bing wallpaper of the day and sets as both lock screen and desktop wallpaper (user selectable on GNOME versions that support it) * Doesn't poll continuously - only once per day and on startup (schedules a refresh when Bing is due to update) * random mode (from previously downloaded wallpapers) *NEW: select/cycle wallpaper through previously downloaded images * Language support: English (en), German (de), Dutch (nl), Italian (it), Polish (pl), Chinese (zh_CN, zh_TW), French (fr), Portuguese (pt), Ukrainian (uk), Russian (ru_RU), Spanish (es), Korean (ko), Indonesian (id), Catalan (ca), Norwegian Bokmål (nb) & Nynorsk (ni), Swedish (sv), Arabic (ar), Hungarian (hu) and Japanese (ja) - a HUGE thanks to the translators This extension was forked from the NASA APOD extension by Elinvention (https://github.com/Elinvention) and inspired by Bing Desktop Wallpaper Changer by Utkarsh Gupta (https://github.com/UtkarshGpta). Always restart GNOME after manually updating extensions. Please report bugs to the GitHub page below:

Extension Homepage
https://github.com/neffo/bing-wallpaper-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Is there any reason for not using ~ for home folder?
neffo posted a review
Readability reasons, mostly. It sort of mirrors how Nautilus represents sub-folders of the user's home folder. (It is a less ambiguous.) I hadn't intended to use other 'bash-style' variable name replacements though. It's used to store picture directory relative path in the case of the user's home folder being moved or changing for some other reason. The format could be changed if you think it's bad form though.
JustPerfection waiting for author
I think ~ is better for future reviews. Because if somehow that value get used in spawn command in the future, we (reviewers) may miss that. And we are against user changeable variables for spawn commands. But let me know if you want to use `$HOME`. We can approve, since it is just a placeholder not an actual variable (at least for now).
neffo posted a review
I can fix this and resubmit.
JustPerfection rejected
Ok. Please send the fix.