Review of "Bing Wallpaper" version 47

Details Page Preview

Bring some color to your GNOME desktop by syncing your desktop and lockscreen wallpapers with today's Microsoft Bing image of the day (the image you see when you visit Bing.com) with this extension. The intention of this extension is to just do what it needs to do and stay out of your way, with a few optional features to improve quality-of-life. *Disclaimer*: this extension is unofficial and not affiliated with Bing or Microsoft in any way. Images are protected by copyright and are licensed only for use as wallpapers. Features: * UHD resolution wallpapers * Automatically fetches current Bing wallpaper of the day and sets as both lock screen and desktop wallpaper (user selectable on GNOME versions that support it) * random mode (from previously downloaded wallpapers) * Language support: English (en), German (de), Dutch (nl), Italian (it), Polish (pl), Chinese (zh_CN, zh_TW), French (fr_FR), Portuguese (pt, pt_BR), Ukrainian (uk), Russian (ru_RU), Spanish (es), Korean (ko), Indonesian (id), Catalan (ca), Norwegian Bokmål (nb) & Nynorsk (nn), Swedish (sv), Arabic (ar), Hungarian (hu), Japanese (ja), Czech (cs_CZ), Finnish (fi_FI) and Turkish (tr), Persian (fa_ir) - a HUGE thanks to the translators Always restart GNOME after manually updating extensions. Please report bugs to the GitHub page below:

Extension Homepage
https://github.com/neffo/bing-wallpaper-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

neffo posted a review
Changes: - removed selective disable - removed unused imports, and subsequent unused file - removed unused functions and logic - replaced lookupByUUID with parameter passing
JustPerfection rejected
Thanks! but now you're not disabling and nulling out `blur` at all. I'm actually saying that instance (line 127 extension.js) shouldn't be in global scope. It should be inside the class using it and you should call `blur._disable()` on destroy. Btw, use `console.*` instead of `print`: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging
neffo posted a review
Yeah, shouldn't have tried to fix that with a tried brain. Will fix both.