Review of "Desktop Icons NG (DING)" version 40

Details Page Preview

Adds icons to the desktop. Fork of the original Desktop Icons extension, with several enhancements .

Extension Homepage
https://gitlab.com/rastersoft/desktop-icons-ng

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. You should remove the timeouts in disable: - line 164, 269 (dbusUtils.js) - line 282 (extension.js) - line 91, 99 (fileItem.js) - line 38 (fileItemMenu.js) 2. Instead of get_schema (in prefswindow.js) you can use `ExtensionUtils.getSettings()`: https://gitlab.gnome.org/GNOME/gnome-shell/blob/main/js/misc/extensionUtils.js
rastersoft waiting for author
The extension itself is comprised only of the files "extension.js", "gnomeShellOverride.js" and "emulateX11WindowType.js", so only the timeout at line 282 has to be removed. About the schemas, when was it included? Just to be sure that in was already in Gnome Shell 3.38.
JustPerfection waiting for author
1. What happens if those timeouts happen in lock screen (When extension got disabled)? 2. Yes, you can use it for 3.34 and higher.
rastersoft posted a review
1. The other files are for a pure-GTK3 application that is launched from the extension. When the extension is disabled, the application is terminated, so there is no problem. 2. About the schemas, the current code allows to read the schemas both from the extension and from the GTK3 application. That's why we still use them.
rastersoft waiting for author
Anyway, I already uploaded version 41 which fixes the timeout in 'extension.js'.
JustPerfection rejected
Newer version approved.