Review of "Desktop Icons NG (DING)" version 78

Details Page Preview

Adds icons to the desktop. Fork of the original Desktop Icons extension, with several enhancements .

Extension Homepage
https://gitlab.com/rastersoft/desktop-icons-ng

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Did you test `window.maximize()` on 49? Isn't it crashing the shell? Also, the port guide is ready but until we release it on gjs.guide, you can read [this section](https://gitlab.gnome.org/World/javascript/gjs-guide/-/merge_requests/309/diffs#d4583e03ecd8be7e157681ec1a803de7dd7e1fb8_0_120).
rastersoft posted a review
No, it doesn't crash it... Anyway, are you talking about the maximize() at app/desktopGrid.js? That one is running in the Gtk application, not inside Gnome Shell. The other ones, the ones in emulateX11WindowType.js, those can have problems... I'll review that. I presume that, instead of checking `window.maximized_vertically`, I have to use `get_maximize_flags()` and check if that one is set... and if not, set it with `set_maximize_flags()` and then call `window.maximize()`, without parameters. Is that?
JustPerfection posted a review
Yeah, the one in the shell process. `window.maximize()` doesn't have any parameters anymore, but I guess the maximize feature is buggy at the moment, and it's best to wait until that is fixed. There is a backtrace Florian mentioned here: https://matrix.to/#/!hCGqHbXRuMrvWnudnP:gnome.org/$y5B4o8FQgbptZA8T8tZ6Ev3iRkjldoITxNx-8_QvfLM?via=gnome.org&via=matrix.org&via=fedora.im If you've tested that and didn't have the issue, I can approve this.
rastersoft posted a review
That code is only called when there is a "maximize" state change, so it really wasn't tested, sorry. I did a test now and it just shows an error in the journal, but no crash. Anyway, I prepared a patch that detects the new API and uses it. I'll close this and prepare a new upload. BTW: I can only choose "No change" below. There is no "close" option for me...
rastersoft auto- rejected
Auto-rejected because of new version 79 was uploaded
JustPerfection posted a review
No problem. Only reviewers can reject and approve. Thanks for the fix btw.