Adds icons to the desktop. Fork of the original Desktop Icons extension, with several enhancements .
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
| Version | Status |
|---|---|
| 82 | Active |
| 81 | Inactive |
| 80 | Inactive |
| 79 | Inactive |
| 78 | Rejected |
| 77 | Active |
| 76 | Active |
| 75 | Inactive |
| 74 | Rejected |
| 73 | Active |
| 72 | Active |
| 71 | Active |
| 70 | Inactive |
| 69 | Inactive |
| 68 | Inactive |
| 67 | Inactive |
| 66 | Active |
| 65 | Active |
| 64 | Inactive |
| 63 | Active |
| 62 | Inactive |
| 61 | Active |
| 60 | Active |
| 59 | Rejected |
| 58 | Active |
| 57 | Inactive |
| 56 | Inactive |
| 55 | Rejected |
| 54 | Active |
| 53 | Active |
| 52 | Active |
| 51 | Rejected |
| 50 | Active |
| 49 | Active |
| 48 | Rejected |
| 47 | Rejected |
| 46 | Active |
| 45 | Active |
| 44 | Active |
| 43 | Active |
| 42 | Inactive |
| 41 | Rejected |
| 40 | Rejected |
| 39 | Active |
| 38 | Active |
| 37 | Active |
| 36 | Active |
| 35 | Inactive |
| 34 | Inactive |
| 33 | Inactive |
| 32 | Inactive |
| 31 | Inactive |
| 30 | Inactive |
| 29 | Inactive |
| 28 | Inactive |
| 27 | Inactive |
| 26 | Inactive |
| 25 | Rejected |
| 24 | Rejected |
| 23 | Rejected |
| 22 | Inactive |
| 21 | Inactive |
| 20 | Inactive |
| 19 | Inactive |
| 18 | Inactive |
| 17 | Active |
| 16 | Inactive |
| 15 | Inactive |
| 14 | Inactive |
| 13 | Inactive |
| 12 | Inactive |
| 11 | Inactive |
| 10 | Inactive |
| 9 | Inactive |
| 8 | Inactive |
| 7 | Inactive |
| 6 | Inactive |
| 5 | Rejected |
| 4 | Rejected |
| 3 | Rejected |
| 2 | Rejected |
| 1 | Rejected |
Did you test `window.maximize()` on 49? Isn't it crashing the shell? Also, the port guide is ready but until we release it on gjs.guide, you can read [this section](https://gitlab.gnome.org/World/javascript/gjs-guide/-/merge_requests/309/diffs#d4583e03ecd8be7e157681ec1a803de7dd7e1fb8_0_120).
No, it doesn't crash it... Anyway, are you talking about the maximize() at app/desktopGrid.js? That one is running in the Gtk application, not inside Gnome Shell. The other ones, the ones in emulateX11WindowType.js, those can have problems... I'll review that. I presume that, instead of checking `window.maximized_vertically`, I have to use `get_maximize_flags()` and check if that one is set... and if not, set it with `set_maximize_flags()` and then call `window.maximize()`, without parameters. Is that?
Yeah, the one in the shell process. `window.maximize()` doesn't have any parameters anymore, but I guess the maximize feature is buggy at the moment, and it's best to wait until that is fixed. There is a backtrace Florian mentioned here: https://matrix.to/#/!hCGqHbXRuMrvWnudnP:gnome.org/$y5B4o8FQgbptZA8T8tZ6Ev3iRkjldoITxNx-8_QvfLM?via=gnome.org&via=matrix.org&via=fedora.im If you've tested that and didn't have the issue, I can approve this.
That code is only called when there is a "maximize" state change, so it really wasn't tested, sorry. I did a test now and it just shows an error in the journal, but no crash. Anyway, I prepared a patch that detects the new API and uses it. I'll close this and prepare a new upload. BTW: I can only choose "No change" below. There is no "close" option for me...
No problem. Only reviewers can reject and approve. Thanks for the fix btw.
Desktop Icons NG (DING)