Review of "Dash to Dock for COSMIC" version 5

Details Page Preview

A Dash to Dock fork for the COSMIC/GNOME Shell, fixes conflicts with Cosmic Workspace. It prevents Cosmic Workspaces from breaking after suspend. Added Features: Border Radius Border Margins Icon Alignment Etc.

Extension Homepage
https://github.com/halfmexican/dash-to-dock-pop/tree/ubuntu-dock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

halfmexican2 posted a review
Added more features such as changing border radius and margin size
JustPerfection rejected
1. The uuid is in wrong format: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed If you change the uuid now, it will be moved to new extension. So I think it's a little late for changing it. 2. Remove unused files and folders: - .eslintrc.yml - .github/workflows/make.yml - .gitignore - Makefile - _stylesheet.scss - debian folder - default.nix - .po files - schemas/10_ubuntu-dock.gschema.override https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 3. Timeout should be removed on disable: - line 788, 230 (appIcons.js) - line 470 (dash.js) - line 821, 905, 1444 (docking.js) - line 1034 (locations.js) https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. Also do this in disable: ```js dockManager = null; ``` 5. Don't do unnecessary try catch in disable. 6. What's the reason for making the prefs stand alone app? You can open the prefs with `ExtensionUtils.openPrefs()` from extension.js side. 7. All timeouts in prefs.js should be removed on `close-request` of the window: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow 8. Why are you using the original version schema (line 49 `schemas/org.gnome.shell.extensions.dash-to-dock.gschema.xml`)? You want to create the super set of dash to dock? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions