Review of "Dash to Dock for COSMIC" version 7

Details Page Preview

A Dash to Dock fork for the COSMIC/GNOME Shell, fixes conflicts with Cosmic Workspace. It prevents Cosmic Workspaces from breaking after suspend. Added Features: Border Radius Border Margins Icon Alignment Etc.

Extension Homepage
https://github.com/halfmexican/dash-to-dock-pop/tree/ubuntu-dock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Remove the `_ensureActorVisibilityTimeoutId` timeout inside `DockDash.onDestroy()` (dash.js). 2. Why are you holding the timeouts in dock (line 1470 docking.js)? Hold it in the same object and remove it on destroy of the same object. 3. `this` doesn't mean anything in that callback function (line 1163-1190 prefs.js). Create `Settings.removeTimeouts()` function and do those timeout removal inside that. After that you can call that inside the `close-request` callback. 4. You are not deleting all of the timeouts in prefs.