Review of "Dash to Dock for COSMIC" version 12

Details Page Preview

A Dash to Dock fork for the COSMIC/GNOME Shell, fixes conflicts with Cosmic Workspace. It prevents Cosmic Workspaces from breaking after suspend. Added Features: Border Radius Border Margins Icon Alignment Etc.

Extension Homepage
https://github.com/halfmexican/dash-to-dock-pop/tree/ubuntu-dock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

halfmexican2 posted a review
I thought I correctly removed the timeouts this time around. I removed the_ensureActorVisibilityTimeoutId from destroy. I based this off the newer Dash to Dock for Gnome 42. So I assume I just need to stop holding timeouts in dock in docking.js?
halfmexican2 posted a review
Hey dude, I'm sorry for like probably wasting hours of your life. I'm a comp sci student and I just made this work well enough for me. I apologize for my repeated incompetence. Have a good day Also added the ability to align the dock to different sides of the screen, which I shamelessly stole from the cosmic dock
JustPerfection rejected
Hi, The changes you are doing in the recent versions are ok but please fix the issues from version 7 and 9 to get it approved.
JustPerfection posted a review
You should remove `this._ensureActorVisibilityTimeoutId` timeout in `DockDash.onDestroy()` (dash.js), So add these lines to that function can solve the issue: ```js if (this._ensureActorVisibilityTimeoutId) { GLib.source_remove(this._ensureActorVisibilityTimeoutId); this._ensureActorVisibilityTimeoutId = null; } ```
halfmexican2 posted a review
That makes so much sense. thank you