Review of "Dash to Dock for COSMIC" version 6

Details Page Preview

A Dash to Dock fork for the COSMIC/GNOME Shell, fixes conflicts with Cosmic Workspace. It prevents Cosmic Workspaces from breaking after suspend. Added Features: Border Radius Border Margins Icon Alignment Etc.

Extension Homepage
https://github.com/halfmexican/dash-to-dock-pop/tree/ubuntu-dock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

halfmexican2 posted a review
uuid is still in wrong format so I can't change it I removed useless and unused files Attempted to remove timeouts on disable. I might've messed up added dockManager = null; in disable got rid of try catch in disable attempted to remove timeouts on close request I renamed and changed schema file to not conflict with dash to dock I'm probably still wrong in alot of places so help with be appreaciated
JustPerfection rejected
1. What is `this.re` doing in line 109 (appIcons.js)? 2. You are deleting timeouts in disable while they belong to a class which you are destroying it in disable. So, why don't you delete those timeouts in destroy? It's very hard to track and review. 3. Most timeouts you are deleting in disable doesn't belong to `Docking.DockManager`. So, technically, you still didn't remove most of those timeouts. Again, they should be removed in the destroy of the same object. 4. prefs.js is still doing that stand alone gtk app thing (line 1186-1201) without any good reason. After removing those lines, line 3-4, 19-27 (prefs.js) should be removed. 5. Still, there is an uncleaned timeout in prefs.js line 388. 6. Remove the newly added timeouts in the same class: - _triggerTimeoutId line 904 docking.js - locationId line 1036 locations.js 7. You forgot to change the gettext domain in metadata.json. 8. The `close-request` you are using in prefs.js is related to stand alone app, not prefs window.