Review of "Wayland or X11" version 1

Details Page Preview

Am I using Wayland or X11?

Extension Homepage
https://github.com/injcristianrojas/waylandorx11

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't do spawn command for something you can do in gjs: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries You can use `Meta`: https://gjs-docs.gnome.org/meta9~9_api/meta.is_wayland_compositor ```js const { Meta } = imports.gi; if (!Meta.is_wayland_compositor()) { log('Wayland'); } else { log('x11'); } ``` 2. You don't need to use `log()` on each enable and disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging 3. You don't use schemas, so you need to delete `settings-schema` from metadata.json. Same for `gettext-domain`. If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
injcristianrojas posted a review
Thanks for the advice. Version 4 is up.