Review "UPower Battery" version 1 - GNOME Shell Extensions

Review of "UPower Battery" version 1

Details Page Preview

UPower Battery

by mouse-battery

UPower Battery Indicator.

Extension Homepage: https://github.com/codilia/upower-battery

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Active
11	Rejected
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Rejected

Previous Reviews on this Version

JustPerfection rejected June 21, 2022

1. You should not use the same property name for both idle_add and timeout (_loop in lines 61 and 67). 2. Remove both idle and timeout in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Fix the indendations (line 31-42, 70-126 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice 4. Log should be only available in debug mode: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#no-excessive-logging If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions