Review of "Dash2Dock Animated" version 15

Details Page Preview

The Animated & Effectful Dock

Extension Homepage
https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
If you want to remove all timers in `clearAllTimers` why these function don't collect the ids in `_running_sequences` (utils.js)? - runSequence - runDebounce - runLoop If you don't do that, the review process will be so hard for us since you have different names for creating timeouts.
icedman posted a review
runSequence, runDebounce, runLoop are wrappers to setInterval. They return an object { _timeoutId, func, delay, [name] }, wherein the IDs are saved. I wrapped the IDs in an object so that I could assign useful variables or functions, and especially names for easier debugging. Typically, I can run: seq = runSequence(...) clearSequence(seq) // clears the timer if necessary I also added a global functions beginTimer - this is where the sequence is saved in _running_sequences. clearAllTimers - this will run clearSequenece for all pending timers when the extension is disabled. beginTimer(runSequence(...)) // the sequence object is saved (along with the timeoutId) beginTimer(runSequence(...)) clearAllTimers() These are useful to me for debugging purposes. I can for example run getRunningSequences() and check that pending timers will sensible names rather than just IDs. This setup has allowed me to hunt down rogue timers and animations. It also allowed be to create a somewhat automated test (diagnostics.js) where a large number of sequences are managed. There should typically no more that one sequence running in my extension - even after running the diagnostics. And there be 2-3 more when animations are running. I apologize for all these wrappers. I can refactor this for easier reading - perhaps create a singleton class.
icedman posted a review
I will refactor this code. I have two other extensions using the timer code. Please reject for now that. Thanks.
icedman posted a review
I will refactor this code. I have two other extensions using the timer code. Please reject for now that. Thanks.
JustPerfection rejected