Review of "Dash2Dock Animated" version 31

Details Page Preview

The Animated & Effectful Dock

Extension Homepage
https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `_extension.js`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. You cannot import Gdk to the shell process (line 2 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 3. You cannot do `run_dispose()` in extensions (line 436 effects/lamp_animation.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 4. Where do you clean up `declarations` and `code` on disable? - line 27-28 effects/color_effect.js - line 28-29 effects/monochrome_effect.js - line 27-28 effects/tint_effect.js