Review "Dash2Dock Animated" version 31

Review of "Dash2Dock Animated" version 31

Details Page Preview

Dash2Dock Animated

by icedman

The Animated & Effectful Dock

Extension Homepage: https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
71	Active
70	Active
69	Active
68	Active
67	Rejected
66	Active
65	Active
64	Active
63	Inactive
62	Rejected
61	Rejected
60	Rejected
59	Rejected
58	Rejected
57	Active
56	Rejected
55	Rejected
54	Active
53	Rejected
52	Rejected
51	Rejected
50	Rejected
49	Active
48	Rejected
47	Rejected
46	Inactive
45	Active
44	Active
43	Inactive
42	Inactive
41	Rejected
40	Rejected
39	Rejected
38	Active
37	Active
36	Inactive
35	Active
34	Active
33	Rejected
32	Active
31	Rejected
30	Active
29	Rejected
28	Active
27	Active
26	Inactive
25	Inactive
24	Active
23	Active
22	Inactive
21	Inactive
20	Active
19	Active
18	Rejected
17	Active
16	Active
15	Rejected
14	Active
13	Rejected
12	Active
11	Active
10	Rejected
9	Active
8	Active
7	Inactive
6	Inactive
5	Inactive
4	Active
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected September 23, 2023

1. Please remove `_extension.js`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. You cannot import Gdk to the shell process (line 2 utils.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 3. You cannot do `run_dispose()` in extensions (line 436 effects/lamp_animation.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 4. Where do you clean up `declarations` and `code` on disable? - line 27-28 effects/color_effect.js - line 28-29 effects/monochrome_effect.js - line 27-28 effects/tint_effect.js