Review of "Notifications Alert" version 45

Details Page Preview

Changes the color of the time and date indicator in the top bar when there are unread notifications. Colors and blinking are customizable. If you have questions, please take a look at the FAQ: http://goo.gl/lmwtW Credits: The idea of painting the message on user's menu was borrowed from 'Pidgin Persistent Notification' extension by nemo. The code itself has some parts forked from 'Message Notifier' extension by barisione, 'Media player indicator' extension by eon and convenience.js from git.gnome.org/gnome-shell-extensions. The blink idea and it's initial code was written by hossman. The initial gnome 3.10 support was done by Anthony25. The filtering support was done by ilgarmehmetali

Extension Homepage
https://github.com/bellini666/gnome-shell-notifications-alert

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove .po and .pot files: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Move line 216 (extension.js) to top of the function. so it can get removed whenever that function is getting called. No matter `this._hasStyleAdded` is true. Because timeouts can get delayed. 4. Move everything from init to enable and null them out in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 5. Also null out `messageStyleHandler` in disable. 6. Don't create settings object as global because after window close it won't get garbage collected (prefs.js line 168). 7. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (line 33-76 lib.js): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions