Review of "Desktop Lyric" version 17

Details Page Preview

Show the lyric of playing songs on the desktop For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/desktop-lyric

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Inactive
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Inactive
9 Inactive
8 Inactive
7 Active
6 Inactive
5 Inactive
4 Inactive
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
There isn't obvious how the timeouts and signals is getting removed on disable.
grroot posted a review
Obviously, I point out timeouts are removed when the `destroy` signals emit in `fubar.js:L50` as required in Light Dict's review: https://extensions.gnome.org/review/39618 It's also obviously that signals are automatically disconnected when the object is destroyed, as the upstream API guaranteed: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/signalTracker.js Could I ask another reviewer to determine if it is obvious?
JustPerfection posted a review
Sure! I let the other reviewers know. Please wait until other reviewers join the discussion.