Review of "Cronomix" version 2

Details Page Preview

All-in-one timer, stopwatch, pomodoro, alarms and todos

Extension Homepage
https://github.com/zagortenay333/cronomix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

zagortenay333 posted a review
Alright, I found a way to fix the blank lines. As for the name, I'm still not sure what the issues is. I just want to change the name. If the name cannot be changed in place, then I'll upload this as a new extension.
JustPerfection rejected
1. Please remove the timeouts on destroy: - line 108 applets/pomodoro.js - line 74 applets/stopwatch.js - line 92 applets/timer.js - line 189 applets/todo/tracker.js - line 64 utils/entry.js - line 111 and 118 utils/markup/editor.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. You cannot create objects in global scope which is the same as init (line 591 utils/markup/renderer.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization