Review of "Cronomix" version 15

Details Page Preview

All-in-one timer, stopwatch, pomodoro, alarms and todo

Extension Homepage
https://github.com/zagortenay333/cronomix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

zagortenay333 posted a review
Sorry I think I messed something up here. Reject this version.
JustPerfection rejected
1. Please remove `session-modes`: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. What is the reason for unnecessary comments (`/*234h1764d7482a3a*/`)?
zagortenay333 posted a review
The comments are a result of a mess up. They shouldn't be there. Btw, why remove session modes? I thought extensions are allowed to run on the lock screen?
JustPerfection posted a review
1. > All signals related to keyboard events MUST be disconnected in unlock-dialog session mode. 2. > The `disable()` function MUST have a comment explaining why you are using `unlock-dialog`. [EGO Review Guidelines: Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html)
zagortenay333 posted a review
Wow that's ridiculous. There is no way to disconnect all keyboard signals without an overhaul of the whole extension. The lock screen already grabs any keyboard events before they get to the my extension. You can verify this. That's a bummer :(