Review of "Cronomix" version 23

Details Page Preview

All-in-one timer, stopwatch, pomodoro, alarm, todo, and flashcards extension

Extension Homepage
https://github.com/zagortenay333/cronomix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Ok, but what do you mean by "because it's a timer extension"? Do you want the timer to still work on the lock screen? When you use session mode, on locked, your extension can be disabled and re-enabled many times. That's how the shell is rebasing. If keeping the timeout active is your goal here, I don't think that will be precise.
zagortenay333 posted a review
Yes I want the timer to keep ticking. I tested it and it works, the extension does not get disabled when transitioning to lock screen. I know that in a previous version of gnome shell (below 48) the extension would get disabled like you described which defeats the point. Are you saying this is how gs still works? :(
JustPerfection posted a review
It all depends on the order. Please take a look at the shell code for this: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/63bf8674ff4a6c480da2ff03ff600094128f1ae7/js/ui/extensionSystem.js#L194-200
zagortenay333 posted a review
Thank you for pointing that out. That's a bummer. :( I guess we'll keep this as is because it will work for some people. Do you know what determines the order of extensions? I just installed arc menu which alphabetically precedes cronomix and everything still works correctly.
JustPerfection rejected
It's based on extension order: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/63bf8674ff4a6c480da2ff03ff600094128f1ae7/js/ui/extensionSystem.js#L268 Anyway, we cannot approve session mode based on the faulty behavior. Also, the key binding is not allowed when you are using session modes: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#session-modes
zagortenay333 posted a review
I disabled the keybindings when in lock screen.
JustPerfection posted a review
Line 62 `utils/keymap.js` is the keybinding add. Anyway, even removing those won't help to get approval for session modes since this is not a good case for `unlock-dialog`.