Review of "Cronomix" version 7

Details Page Preview

All-in-one timer, stopwatch, pomodoro, alarms and todos

Extension Homepage
https://github.com/zagortenay333/cronomix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this.ext = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. You cannot import `Gtk` to the GNOME Shell process (line 1 `utils/keymap.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 3. `lookupByUUID()` is a bad practice (line 13 `utils/misc.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection) or set a global var as `this` in the entry point that other modules using it (it should be null out in disable). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions