Review of "Cronomix" version 7

Details Page Preview

All-in-one timer, stopwatch, pomodoro, alarm, todo, and flashcards extension

Extension Homepage
https://github.com/zagortenay333/cronomix

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Rejected
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Also null out in disable: ```js this.ext = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. You cannot import `Gtk` to the GNOME Shell process (line 1 `utils/keymap.js`): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell) 3. `lookupByUUID()` is a bad practice (line 13 `utils/misc.js`). You can send `this` from the entry point to the class needing it when it's possible (dependency injection) or set a global var as `this` in the entry point that other modules using it (it should be null out in disable). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions