Review of "IBus Tweaker" version 42

Details Page Preview

Tweaker of IBus for orientation, theme, font, input mode and clipboard history For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/ibus-tweaker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please move line 25-28 (extension.js) to enable and null them out in disable. 2. Why do you use `getSignalHolder(this)` for `connectObject()` when you can use `this`?
grroot posted a review
> 1. Please move line 25-28 (extension.js) to enable and null them out in disable. These singletons always exist for the IBus users, so nothing unexpected is created. Is it necessary to add more assignment statements? > 2. Why do you use `getSignalHolder(this)` for `connectObject()` when you can use `this`? It can save the time of checking whether "this" can be used, and most of them are one-shot operations.
JustPerfection posted a review
1. You cannot create instance of objects in global scope because they need to clean up on disable. If you don't do that, it will break both of these rules: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Ok. I still think you should only use `this` but it's ok if you don't want to change that. All of those calls return `this` atm.
grroot posted a review
> 1. You cannot create instance of objects in global scope because they need to clean up on disable. Well, in practice, they've all been created by the Gnome Shell. How about this? ``` const InputManager = Main.panel.statusArea.keyboard._inputSourceManager; const IBusManager = InputManager._ibusManager; const IBusPopup = IBusManager._candidatePopup; const IBusPopupArea = IBusPopup._candidateArea; ```
JustPerfection posted a review
Yest, you can do that since they are the reference.