Review of "X11 Gestures" version 18

Details Page Preview

Enable GNOME Shell multi-touch gestures on X11. Requires Touchégg https://github.com/JoseExposito/touchegg#readme

Extension Homepage
https://github.com/JoseExposito/gnome-shell-extension-x11gestures

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
24 Active
23 Active
22 Active
21 Rejected
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Inactive
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instance of objects in global scope: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization - line 228 `src/touchegg/ToucheggClient.js` - line 51 `src/utils/Logger.js` 2. Timeout should be removed on destroy or disable (line 166 src/touchegg/ToucheggClient.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Please remove `45.rc` from version. Not needed when you use `45`. 4. You cannot import `Gtk` and `Gdk` to GNOME Shell process (line 19, 21 src/utils/Notification.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 5. Use `TextDecoder` instead of `byteArray` (line 27 src/touchegg/ToucheggConfig.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder
JoseExposito posted a review
Hi @JustPerfection, Thanks a lot for your detailed review. I fixed all the problems and submitted a new release: https://extensions.gnome.org/review/45982