Review of "Bitcoin Markets" version 69

Details Page Preview

Display info on various crypto-currency exchanges.

Extension Homepage
https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `gjs_http.js` since it hasn't been used (not compatible with ego btw). 2. Please remove versions from the imports. 3. Also null out in disable: ```js BitcoinMarketsExtension.instance = null; this._indicatorCollection = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. You cannot import `Gtk` to the GNOME Shell process (line 11 extension.js): [EGO Review Guidelines: import](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-import-gtk-libraries-in-gnome-shell)
oal posted a review
Thank you! > 2. Please remove versions from the imports. Do you mean stripping the `?version=` from these? ``` import St from 'gi://St?version=13'; import Clutter from 'gi://Clutter?version=13'; import GObject from 'gi://GObject?version=2.0'; import GLib from 'gi://GLib?version=2.0'; import Soup from 'gi://Soup?version=3.0'; import Gio from 'gi://Gio?version=2.0'; ```
JustPerfection posted a review
Yes! Versions are specified on initiation (shell process init). Also in prefs parent module.