Review "Bitcoin Markets" version 61 - GNOME Shell Extensions

Review of "Bitcoin Markets" version 61

Details Page Preview

Bitcoin Markets

by oal

Display info on various crypto-currency exchanges.

Extension Homepage: https://github.com/OttoAllmendinger/gnome-shell-bitcoin-markets/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
72	Active
71	Active
70	Active
69	Rejected
68	Active
67	Active
66	Active
65	Active
64	Active
63	Active
62	Inactive
61	Rejected
60	Rejected
59	Rejected
58	Active
57	Active
56	Rejected
55	Active
54	Rejected
53	Active
52	Active
51	Active
50	Rejected
49	Active
48	Active
47	Active
46	Rejected
45	Active
44	Active
43	Active
42	Rejected
41	Active
40	Active
39	Active
38	Rejected
37	Rejected
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Active
29	Active
28	Active
27	Rejected
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Rejected
18	Active
17	Active
16	Active
15	Rejected
14	Active
13	Active
12	Rejected
11	Rejected
10	Rejected
9	Active
8	Active
7	Active
6	Active
5	Rejected
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

oal posted a review November 20, 2021

When a timeout has already been cleared, `removeAllTimeouts()` will produce an info-level log on the second attempt. I hope that is not an issue.

JustPerfection rejected November 20, 2021

`removeAllTimeouts` should also do `timeoutIds = [];`. It will go throw the same id on each disable (lock mode for example) and can cause so many warnings in users log. Please fix that and it will be approved.