Review of "Bitcoin Markets" version 76

Details Page Preview

Display info on various crypto-currency exchanges.

Extension Homepage
https://github.com/rossigee/gnome-shell-bitcoin-markets/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed in disable (line 955 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. You should cleanup line 955-956 `extension.js` in disable. 3. Please fix the transpile config so the final result doesn't have artifacts like line 22-32, 57 `prefs.js`.
rossigee posted a review
The extension properly implements the "remove main loop sources" guideline. In disable(), it calls removeAllTimeouts() which removes all tracked timeout sources, and IndicatorCollection.destroy() stops all poll loops and disconnects signals. I can't clearly see what you're referring to with your other comments.
rossigee posted a review
This wasn't the one I wanted to release anyway. I accidentally uploaded the wrong zip file. It's the later one that needs reviewing.